Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose cardinality checker via the cli #988

Merged
merged 2 commits into from
Aug 7, 2023
Merged

Expose cardinality checker via the cli #988

merged 2 commits into from
Aug 7, 2023

Conversation

glguy
Copy link
Contributor

@glguy glguy commented Aug 4, 2023

See #986

@glguy glguy self-assigned this Aug 4, 2023
@saratge
Copy link
Contributor

saratge commented Aug 4, 2023

I am getting the error shown below after ingesting using this ingestion package: gsn_demo.zip

image

The error appears to arise from python semtk client

@weisenje
Copy link
Contributor

weisenje commented Aug 7, 2023

Checking cardinality against the package that @saratge is loading generates this SPARQL, which errors. @cuddihyge and @weisenje will investigate further.

SELECT DISTINCT ?subject (COUNT(?object) AS ?object_COUNT)  
    FROM <[http://rack001/data>](http://rack001/data%3E)
WHERE { 
  ?subject a ?subject_class .   VALUES ?subject_class { b0  } .
OPTIONAL { ?subject <[http://sadl.org/GSN-Pattern-core.sadl#isPat>](http://sadl.org/GSN-Pattern-core.sadl#isPat%3E) ?object } . 
} GROUP BY ?subject 
  HAVING ( ?object_COUNT != 1 )

@cuddihyge
Copy link
Contributor

The cardinality bug has to do with @saratge 's use of unions inside SADL statements, which are correct, but no one had used before with SemTK.
I can fix it on the master branch.
This bug has nothing to do with @glguy 's work on this branch.
I'm fine merging this branch.
The bug will persist until I make another semtk release and add it to RACK.

@saratge saratge merged commit cf5439d into master Aug 7, 2023
4 checks passed
@cuddihyge
Copy link
Contributor

I opened #989 to address the bug.

@weisenje
Copy link
Contributor

weisenje commented Aug 7, 2023

Thanks @glguy. Remember to document this on the Wiki when you get a chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants