Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nested undefined interpolation segfault #1542

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Fix nested undefined interpolation segfault #1542

merged 1 commit into from
Oct 15, 2024

Conversation

Rangi42
Copy link
Contributor

@Rangi42 Rangi42 commented Oct 13, 2024

Fixes #1541

@Rangi42 Rangi42 added bug Unexpected behavior / crashes; to be fixed ASAP! rgbasm This affects RGBASM labels Oct 13, 2024
@Rangi42 Rangi42 added this to the v0.9.0 milestone Oct 13, 2024
@Rangi42 Rangi42 requested a review from ISSOtm October 13, 2024 23:49
ISSOtm
ISSOtm approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@ISSOtm ISSOtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah, the one place it has been missed... *sobs quietly in Rust*

@ISSOtm ISSOtm merged commit a2ff653 into gbdev:master Oct 15, 2024
22 checks passed
@Rangi42 Rangi42 deleted the nested-bad-interpolation branch October 15, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ISSOtm ISSOtm ISSOtm approved these changes

Assignees
No one assigned
Labels
bug Unexpected behavior / crashes; to be fixed ASAP! rgbasm This affects RGBASM
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging this pull request may close these issues.

Segfault when performing nested symbol interpolation on missing symbol
2 participants
@Rangi42 @ISSOtm