Fix warnings when using PHP 8.2 #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Many thanks Tim. I have merged this into the qtype_ordering repository. |
|
Thanks Gordon. |
Chocolate-lightning
pushed a commit
to ilyatregubov/moodle-qtype_ordering
that referenced
this pull request
Jan 15, 2024
Many thanks Tim Hunt for finding and fixing gbateson#80 (avoid warnings with PHP 8.2, Update moodle-plugin-ci config)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Gordon, PHP 8.2 does not like it if you try to set an undelcared fieldon a class. You get warnings like:
PHP Deprecated: Creation of dynamic property qtype_ordering_question::$layouttype is deprecated in C:\Users\tjh238\workspace\ou-moodle2\question\type\questiontypebase.php on line 1015
This is one way it can be fixed. (I also did another commit to update the CI config to test with Moodle 4.3 and PHP 8.2.)