Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consumer: return descriptive error when a nil state is passed into NewJSONFileStore #245

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

consumer: return descriptive error when a nil state is passed into NewJSONFileStore #245

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cd21308
return descriptive error when a nil state is passed into JSONFileStore
Dec 4, 2019
942b89f
- add test
Dec 18, 2019
d1b498f
- extra nil check
Dec 18, 2019
8555b58
- nit
Dec 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions consumer/store_json_file.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,9 @@ var _ Store = &JSONFileStore{} // JSONFileStore is-a Store.
// of the Store's state, which is decoded into, encoded from, and retained
// as JSONFileState.State.
func NewJSONFileStore(rec *recoverylog.Recorder, state interface{}) (*JSONFileStore, error) {
if state == nil {
return nil, errors.New("state must not be nil")
}
var store = &JSONFileStore{
State: state,
fs: recoverylog.RecordedAferoFS{Recorder: rec, Fs: afero.NewOsFs()},
Expand Down