Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Implement HVPA v2 proposal #88

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

amshuman-kr
Copy link
Collaborator

What this PR does / why we need it:

Implement HVPA v2 proposal.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Based on #76 which can now be closed.

Release note:

Change API Group to `autoscaling.gardener.cloud`
The change of API group to `autoscaling.gardener.cloud` is a breaking change and existing Hvpa resources with the old API Group `autoscaling.k8s.io` will NOT be automatically migrated to the new API group.
Implement scale subresource - Now HPA, if deployed, will scale HVPA's scale subresource instead of the HVPA's target
The scaling is not based on HPA/VPA weightage anymore. Max of total resources recommended by HPA/VPA is considered for scaling based on provided scale intervals.

@amshuman-kr amshuman-kr requested a review from a team as a code owner August 31, 2021 19:46
@amshuman-kr amshuman-kr changed the title Implement HVPA v2 proposal [WIP] Implement HVPA v2 proposal Aug 31, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 31, 2021
@gardener-robot gardener-robot added needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Aug 31, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 31, 2021
@amshuman-kr amshuman-kr mentioned this pull request Aug 31, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 14, 2021
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Gaurav Gupta seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Jun 28, 2022
@gardener-robot gardener-robot added the needs/rebase Needs git rebase label Oct 5, 2022
@gardener-robot
Copy link

@amshuman-kr You need rebase this pull request with latest master branch. Please check.

@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Nobody worked on this for 12 months (final aging stage) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/rebase Needs git rebase needs/review Needs review needs/second-opinion Needs second review by someone else size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants