Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added simple init container to calico-node to verify that the cni installation step worked. #78

Merged
merged 1 commit into from
Apr 12, 2021

Conversation

ScheererJ
Copy link
Member

@ScheererJ ScheererJ commented Apr 12, 2021

How to categorize this PR?

/area networking
/kind bug

What this PR does / why we need it:
As #70 is not reproducible, this pull request tries to validate the init container cni installation step within another init container.

Which issue(s) this PR fixes:
Added tracing to get more details regarding #70 .

Special notes for your reviewer:

Release note:

NONE

@ScheererJ ScheererJ requested review from a team as code owners April 12, 2021 13:21
@gardener-robot gardener-robot added area/networking Networking related kind/bug Bug labels Apr 12, 2021
@gardener-robot
Copy link

@ScheererJ Thank you for your contribution.

@gardener-robot gardener-robot added the needs/review Needs review label Apr 12, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 12, 2021
@gardener-robot gardener-robot added the size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) label Apr 12, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 12, 2021
Copy link
Member

@DockToFuture DockToFuture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Apr 12, 2021
@DockToFuture DockToFuture merged commit 54318df into gardener:master Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/networking Networking related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants