-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nix flake enablement for gardenctl-v2 #366
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left the explanations for the other things in open-component-model/ocm#625 (review) since I didn't want to copy paste them here.
Hi, great to see a flake for gardenctl ❤️ Would it be possible to also add an overlay to the flake?: overlays.default = final: prev: {
${pname} = self.packages.${prev.system}.${pname};
}; This would allow users to declaratively install this flake using overrides (e.g., for As When trying out this flake I additionally encountered the following error on shell startup: |
Give me some time to check the pro & cons. I first need the maintainers to merge this PR (but they insist that the vendorhash has to be automated as well ...)
Will check as well. I currently like that this dependency is not made implicit (meaning, the user has to explicitly flake download each tool).
If you setup |
Out of good reason. Take https://github.com/open-component-model/ocm as an example. The PR Make ocm flake.nix ready #625 was merged, and the |
I 100% agree that the
I'm aware that most tools (installed with nix) are "installing" the completion scripts into a location I can use by adding it to I could specify everything on my own, instead of using |
What this PR does / why we need it:
We want to enable gardenctl for the nix community.