Fix RetryUntilPredicate tests, upgrade go lang version to v1.19.4 (#73)

* fix RetryUntilPredicate tests * upgrade go version to 1.19.4
gardener · Jan 6, 2023 · 101f06e · 101f06e
1 parent ef32643
commit 101f06e
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 10 deletions.
diff --git a/.ci/pipeline_definitions b/.ci/pipeline_definitions
@@ -27,11 +27,11 @@ dependency-watchdog:
                 build: ~
     steps:
       check:
-        image: 'golang:1.19.3'
+        image: 'golang:1.19.4'
       test-unit:
-        image: 'golang:1.19.3'
+        image: 'golang:1.19.4'
       build:
-        image: 'golang:1.19.3'
+        image: 'golang:1.19.4'
         output_dir: 'binary'
 
   jobs:

diff --git a/Dockerfile b/Dockerfile
@@ -1,4 +1,4 @@
-FROM golang:1.19.3 AS builder
+FROM golang:1.19.4 AS builder
 
 WORKDIR /go/src/github.com/gardener/dependency-watchdog
 COPY . .

diff --git a/internal/util/retry_test.go b/internal/util/retry_test.go
@@ -131,17 +131,12 @@ func TestRetryUntilPredicateForContextCancelled(t *testing.T) {
 }
 
 func TestRetryUntilPredicateWithBackgroundContext(t *testing.T) {
-	counter := 0
 	table := []struct {
 		predicateFn    func() bool
 		expectedResult bool
 	}{
 		{func() bool { return false }, false},
 		{func() bool { return true }, true},
-		{func() bool {
-			counter++
-			return counter%2 == 0
-		}, true},
 	}
 	for _, entry := range table {
 		g := NewWithT(t)
@@ -154,7 +149,6 @@ func TestRetryUntilPredicateWithBackgroundContext(t *testing.T) {
 		}()
 		wg.Wait()
 	}
-
 }
 
 func TestRetryOnError(t *testing.T) {