Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vpa version file path #273

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Fix vpa version file path #273

merged 2 commits into from
Dec 14, 2023

Conversation

voelzmo
Copy link
Member

@voelzmo voelzmo commented Dec 13, 2023 •
edited
Loading

What this PR does / why we need it:
We have to determine the script path differently, otherwise this breaks in our CI.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

NONE

@gardener-robot gardener-robot added the needs/review Needs review label Dec 13, 2023
@voelzmo voelzmo changed the title Fixvpa version file path Fix vpa version file path Dec 13, 2023
@gardener-robot gardener-robot added the size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) label Dec 13, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 13, 2023
@rishabh-11 rishabh-11 mentioned this pull request Dec 13, 2023
Closed
rishabh-11
rishabh-11 approved these changes Dec 13, 2023
View reviewed changes
Copy link

@rishabh-11 rishabh-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Dec 13, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 13, 2023
@rishabh-11
Copy link

The vertical-pod-autoscaler-machine-controller-manager-provider pipeline job did not run for this PR. Any idea why @voelzmo ?

@rishabh-11 rishabh-11 merged commit 7ae1913 into gardener:machine-controller-manager-provider Dec 14, 2023
10 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Dec 14, 2023
rishabh-11 pushed a commit to rishabh-11/autoscaler that referenced this pull request Dec 14, 2023
@voelzmo @rishabh-11
Fix vpa version file path (gardener#273)
a3c0738 
* Switch VPA pipeline to vpa specific branch

* Fix path to VPA version file in CI scripts
@rishabh-11 rishabh-11 mentioned this pull request Dec 14, 2023
Merged
himanshu-kun pushed a commit that referenced this pull request Dec 15, 2023
@rishabh-11 @voelzmo
Fix vpa version file path (#273) (#274)
4887356 
* Switch VPA pipeline to vpa specific branch

* Fix path to VPA version file in CI scripts

Co-authored-by: Marco Voelz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rishabh-11 rishabh-11 rishabh-11 approved these changes

@himanshu-kun himanshu-kun Awaiting requested review from himanshu-kun

@unmarshall unmarshall Awaiting requested review from unmarshall unmarshall is a code owner

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@voelzmo @rishabh-11 @gardener-robot-ci-3 @gardener-robot