Simtools for single pe derivation

[GernotMaier]

Add a simtool to derive (normalize) the single p.e. amplitude spectrum. At this point, all what it does is to call the norm_spe tool of sim_telarray and write the output both in the format required by sim_telarray and as an astropy table (enriched with metadata).

Plan is to replace norm_spe at a later stage by a simtool.

This PR also includes a small reorganization: camera related modules have now their own main module simtools.camera (e.g., camera_efficiency has been moved there).

Allowed input are:

• space / comma separated csv files
• ecsv table

Missing:

• input / output data validation.
• application documentation (wait merging of PR Use-friendly naming of application documentation #1300)

Copilot reviewed 7 out of 14 changed files in this pull request and generated no comments.

Files not reviewed (7)

• tests/resources/LST_afterpulses.dat: Language not supported
• tests/resources/SinglePhe_spectrum_totalfit_19pixel-average_20200601.csv: Language not supported
• tests/unit_tests/camera/test_camera_efficiency.py: Evaluated as low risk
• tests/conftest.py: Evaluated as low risk
• pyproject.toml: Evaluated as low risk
• src/simtools/applications/validate_camera_efficiency.py: Evaluated as low risk
• tests/unit_tests/simtel/test_simulator_camera_efficiency.py: Evaluated as low risk

Comments suppressed due to low confidence (1)

src/simtools/camera/single_photon_electron_spectrum.py:133

• Potential file reading error. Add a try-except block to handle file reading errors.

with open(self.args_dict['input_spectrum'], encoding='utf-8') as f:

[ctao-dpps-sonarqube]

Analysis Details

0 Issues

• 0 Bugs
• 0 Vulnerabilities
• 0 Code Smells

Coverage and Duplications

• 100.00% Coverage (93.30% Estimated after merge)
• 0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube