Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Starbound support #234

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Add Starbound support #234

merged 1 commit into from
Dec 5, 2024

Conversation

Novaenia
Copy link
Contributor

@Novaenia Novaenia commented Dec 1, 2024

for some reason Starbound returns the server type and environment in uppercase, so I'm converting to lowercase to work around that.

@github-actions github-actions bot added protocol This is something regarding a protocol game This is something regarding a game labels Dec 1, 2024
@cainthebest
Copy link
Member

Hello, ty for the PR! I will review this as soon as i get some free time.

Copy link
Member

@cainthebest cainthebest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR LGTM 🚀

1 thing though, would you be able to update the GAMES.md file. Happy to merge this then.

Copy link
Member

@cainthebest cainthebest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can add this myself actually after merge when coming up with patch

@cainthebest cainthebest merged commit d1eb6d7 into gamedig:main Dec 5, 2024
13 checks passed
@Novaenia Novaenia deleted the starbound branch December 8, 2024 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
game This is something regarding a game protocol This is something regarding a protocol
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants