Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use capture group to find Unity version to support new 6000 versions #639

Merged
merged 1 commit into from
Mar 17, 2024

Conversation

AndrewKahr
Copy link
Member

Changes

Checklist

  • Read the contribution guide and accept the
    code of conduct
  • Docs (If new inputs or outputs have been added or changes to behavior that should be documented. Please make a PR
    in the documentation repo)
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)

Copy link

Cat Gif

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.97%. Comparing base (fc0a52b) to head (b8c45ef).

❗ Current head b8c45ef differs from pull request most recent head b2b7551. Consider uploading reports for the commit b2b7551 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #639      +/-   ##
==========================================
- Coverage   36.99%   36.97%   -0.03%     
==========================================
  Files          77       77              
  Lines        3122     3121       -1     
  Branches      609      645      +36     
==========================================
- Hits         1155     1154       -1     
+ Misses       1967     1824     -143     
- Partials        0      143     +143     
Files Coverage Δ
src/model/unity-versioning.ts 100.00% <100.00%> (ø)

... and 37 files with indirect coverage changes

@AndrewKahr AndrewKahr merged commit 0c16aab into main Mar 17, 2024
52 checks passed
@AndrewKahr AndrewKahr deleted the support-new-version-numbering branch March 17, 2024 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants