Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] ProteoRE prot_features_Uniprot_3species #603

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

combesf
Copy link
Collaborator

@combesf combesf commented Jun 3, 2021

No description provided.

@combesf combesf changed the title [WIP] ProteoRE prot features 3 orga tool [WIP] ProteoRE prot_features_Uniprot_3species Jun 4, 2021
Copy link
Contributor

@foellmelanie foellmelanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
I am looking forward to having this tool in the EU server :)
I made a few comments but I think it's nothing new, the same things I have seen suggested by Björn and Matthias before on other tools.
Best,
Melanie

<option value="copy_paste">Copy/paste your list of IDs</option>
</param>
<when value="copy_paste">
<param name="genelist" type="text" label="Enter a list of IDs separated by tab, space or carriage return into the form field" help="">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not find out what carriage means; why not just sticking to one delimiter option either space or comma as it has anyway to be input manually

@@ -0,0 +1,170 @@
<tool id="prot_features_3orga" name="add protein features" version="2021.06.21">
<description>[UniProt, Human, Mouse, Rat]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this description will be added after the name; you might want to write a full sentence here about the tool

</inputs>

<outputs>
<data name="output" format="tsv" label="Add_${org}_ProteinFeatures_on_${inputtype.genelist.name}">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format="tabular"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more common naming of output files would be: ${tool.name} on ${on_string}: ProteinFeatures

<data name="output" format="tsv" label="Add_${org}_ProteinFeatures_on_${inputtype.genelist.name}">
<filter>inputtype['filetype'] == 'file'</filter>
</data>
<data name="output2" format="tsv" label="Add_${org}_ProteinFeatures_UP">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format="tabular"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here: more common naming of output files would be: ${tool.name} on ${on_string}: ProteinFeatures_UP

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only "tabular" modif is done

@@ -0,0 +1,231 @@
Q3TIA9
Q9D566
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest using tabular files for all txt files with columns

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants