-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] ProteoRE prot_features_Uniprot_3species #603
base: master
Are you sure you want to change the base?
[WIP] ProteoRE prot_features_Uniprot_3species #603
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
I am looking forward to having this tool in the EU server :)
I made a few comments but I think it's nothing new, the same things I have seen suggested by Björn and Matthias before on other tools.
Best,
Melanie
tools/proteore_prot_features_3orga/add_protein_features_3orga.xml
Outdated
Show resolved
Hide resolved
<option value="copy_paste">Copy/paste your list of IDs</option> | ||
</param> | ||
<when value="copy_paste"> | ||
<param name="genelist" type="text" label="Enter a list of IDs separated by tab, space or carriage return into the form field" help=""> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not find out what carriage means; why not just sticking to one delimiter option either space or comma as it has anyway to be input manually
tools/proteore_prot_features_3orga/add_protein_features_3orga.xml
Outdated
Show resolved
Hide resolved
@@ -0,0 +1,170 @@ | |||
<tool id="prot_features_3orga" name="add protein features" version="2021.06.21"> | |||
<description>[UniProt, Human, Mouse, Rat] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this description will be added after the name; you might want to write a full sentence here about the tool
tools/proteore_prot_features_3orga/add_protein_features_3orga.xml
Outdated
Show resolved
Hide resolved
</inputs> | ||
|
||
<outputs> | ||
<data name="output" format="tsv" label="Add_${org}_ProteinFeatures_on_${inputtype.genelist.name}"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
format="tabular"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
more common naming of output files would be: ${tool.name} on ${on_string}: ProteinFeatures
<data name="output" format="tsv" label="Add_${org}_ProteinFeatures_on_${inputtype.genelist.name}"> | ||
<filter>inputtype['filetype'] == 'file'</filter> | ||
</data> | ||
<data name="output2" format="tsv" label="Add_${org}_ProteinFeatures_UP"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
format="tabular"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here: more common naming of output files would be: ${tool.name} on ${on_string}: ProteinFeatures_UP
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only "tabular" modif is done
@@ -0,0 +1,231 @@ | |||
Q3TIA9 | |||
Q9D566 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest using tabular files for all txt files with columns
No description provided.