Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new training for scATAC-seq analysis using SnapATAC2 #4973

Merged
merged 56 commits into from
Jul 11, 2024

Conversation

timonschlegel
Copy link
Contributor

@timonschlegel timonschlegel commented May 28, 2024

Please review :)

@timonschlegel timonschlegel requested a review from a team as a code owner June 23, 2024 20:52
@pavanvidem pavanvidem changed the title [Draft] Add new training for scATAC-seq analysis using SnapATAC2 Add new training for scATAC-seq analysis using SnapATAC2 Jun 23, 2024
Copy link
Member

@pavanvidem pavanvidem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @timonschlegel! Very well structured and clearly written.

Please try to resolve my (minor) review comments.

>
> 4. {% tool [Normalize](toolshed.g2.bx.psu.edu/repos/iuc/scanpy_normalize/scanpy_normalize/1.9.6+galaxy2) %} with the following parameters:
> - {% icon param-file %} *"Annotated data matrix"*: `Anndata log1p` (output of **log1p** {% icon tool %})
> - *"Method used for normalization"*: `Denoising using Markov Affinity-based Graph Imputation of Cells (MAGIC) API 'external.pp.magic'`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a short intro to MAGIC algorithm with a link to the documentation and citation would be nice.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea, I will add it



# Conclusion
{% icon congratulations %} Well done, you’ve made it to the end! You might want to consult your results with this [control history](https://singlecell.usegalaxy.eu/u/timonschlegel/h/test-of-5k-pbmc-tutorial-workflow), or check out the [full workflow](https://singlecell.usegalaxy.eu/u/timonschlegel/w/2combined-snapatac2) for this tutorial.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

links to the control history and the workflow are invalid. Please check.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strange, because they do work for me. I have updated my visable name a few days ago, maybe that is causing the issues? But since I updated the links it works for me.

But I have to change the control history anyway before publishing, since I don't have a history that contains the entire process, because make_fragment_file isn't updated yet. And maybe I will also change the workflow, so that each step is listed individually? And I could add the make_bam-file steps as well

Co-authored-by: Björn Grüning <[email protected]>
bgruening
bgruening previously approved these changes Jul 9, 2024
Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing stuff @timonschlegel!

Copy link
Member

@pavanvidem pavanvidem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

big thanks to @timonschlegel for this great tutorial and workflow

@bgruening bgruening merged commit 4779457 into galaxyproject:main Jul 11, 2024
3 checks passed
@bgruening
Copy link
Member

@timonschlegel please consider writing a small blog post to announce this tutorial :)

@timonschlegel
Copy link
Contributor Author

@bgruening I've now made a PR containing the announcement. I hope everything looks okay :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants