Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update container_resolvers_config_file option #4450

Merged
merged 3 commits into from
Oct 23, 2023

Conversation

pauldg
Copy link
Contributor

@pauldg pauldg commented Oct 21, 2023

It seems that this config option should be renamed from containers_resolvers_config_file to container_resolvers_config_file as indicated here: https://github.com/galaxyproject/galaxy/blob/b54e7a773fbb8476c24071798f648d7305051d2c/lib/galaxy/config/sample/galaxy.yml.sample#L714

Thank you for contributing to the GTN! 💛

Please check that:

  • [ x ] Your pull request has a good title, e.g.
    • "Fix typo in ansible-galaxy tutorial"
    • "Add new transcriptomics tutorial covering a new sequencing technology"
  • Please replace this entire pull request message with a description of your changes, it will help us review your pull request faster
  • Check that your images are allowed to be re-hosted by the GTN

Once these are done, you're ready to go!

Consider sustainable computing with Draft Mode 💚

Is your pull request finished? 100% ready to be merged? Or do you want some time to work on it first (which we encourage! It's great to have visibility)

If not, then please consider creating this pull request as a draft.

Regular pull requests will trigger automated test runs when they are created
and every time you update them.

As a small contribution to sustainable computing, we skip the most energy intensive of these tests for pull requests marked as drafts. Once your pull request is ready to go, then you can click a button saying "Ready for Review" and the tests will be run!

It seems that this config option should be renamed from `containers_resolvers_config_file` to `container_resolvers_config_file` as indicated here: https://github.com/galaxyproject/galaxy/blob/b54e7a773fbb8476c24071798f648d7305051d2c/lib/galaxy/config/sample/galaxy.yml.sample#L714
bgruening
bgruening previously approved these changes Oct 22, 2023
@hexylena
Copy link
Member

The test failure is relevant. Either you can re-knit the patches (somewhat complicated), or you can in this case since you are neither adding nor removing extra lines, fix the other files that mention the same variable:

$ ag containers_resolvers_config_file -l topics/admin
topics/admin/tutorials/job-destinations/tutorial.md
topics/admin/tutorials/data-library/tutorial.md
topics/admin/tutorials/apptainer/tutorial.md
topics/admin/tutorials/k8s-managing-galaxy/tutorial.md

the last one i'd skip updating since it still mentions uwsgi

@hexylena
Copy link
Member

the joys of diffs!

@hexylena hexylena merged commit e9e0f14 into galaxyproject:main Oct 23, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants