NEW LESSON Making clinical datasets FAIR #4446
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkamieniecka
requested review from
a team,
bebatut,
shiltemann and
hexylena
as code owners
hexylena
reviewed
Oct 23, 2023
Comment on lines
686
to
-701
|
|
||
| def self.zenodo_api(contents) | ||
| find_matching_texts(contents, /(zenodo\.org\/api\/files\/)/) | ||
| .map do |idx, _text, selected| | ||
| ReviewDogEmitter.error( | ||
| path: @path, | ||
| idx: idx, | ||
| match_start: selected.begin(1), | ||
| match_end: selected.end(1) + 1, | ||
| replacement: nil, | ||
| message: 'The Zenodo.org/api URLs are not stable, you must use a URL of the format zenodo.org/record/..., apologies we cannot fix automatically.', | ||
| code: 'GTN:032' | ||
| ) | ||
| end | ||
| end | ||
|
|
There was a problem hiding this comment.
really sorry but it looks like something has gone weirdly in the merge here; we just added these lines recently in a PR, but here they're being removed and I suspect it isn't just a "github display the PR weirdly" issue, but part of the commits. Is there any chance you could extract just the files you want from this PR?
There was a problem hiding this comment.
Hi @hexylena I was just writing to you when I spot this comment. Yes I think something went wrong as before the disappearing branches (on our side) PR was linting correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making clinical datasets FAIR: discusses how to make clinical datasets FAIR and why this is important
PR update @hexylena I think this one is fixed now, thanks