Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update anndata - galaxy version 1 #6644

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

nilchia
Copy link
Contributor

@nilchia nilchia commented Dec 17, 2024

FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)

This PR updates anndata with:

  1. when renaming the categories, user can specify if they want to create a new key or just update the previous key
  2. User can use different keys in adata.var to flag genes (to flag not only based on var names)
  3. inspect anndata order is changed so it is less likely for the user to select "the full data matrix"

Thanks @nomadscientist for these nice suggestions ❤️

@nilchia
Copy link
Contributor Author

nilchia commented Dec 17, 2024

@nomadscientist also suggests putting the anndata filter in the scanpy filter section.
I don't know if we should do it because they are from different tool suits, however, this filter option is not a method (API) from anndata but our own script. So maybe we can put it in scanpy tool suit?
What do you say @bgruening @pavanvidem?

@nilchia nilchia marked this pull request as draft December 17, 2024 10:38
@nomadscientist
Copy link
Contributor

Oh this is super exciting!!!! Well done! Amazing!
And great catch on finding out that the filter function there is a Galaxy thing, rather than a Scanpy thing. I think that makes it much more reasonable to include, and then from a user perspective, all the FILTER functions are in the same tool (the Filter tool), then that makes a lot more sense for users.

@pavanvidem
Copy link
Member

Sure, I will move the filter to scanpy filter tool and add a few more metadata copying functions

@pavanvidem
Copy link
Member

Filter functions moved: #6648

@pavanvidem
Copy link
Member

Hopefully, this PR covers most of the functions needed to update the tutorials. Tests need to be added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants