-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EMBOSS] Add Needleall tool (v6) and bump version for needle to v6 #6643
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks fro starting this.
Wondering if we should try to bump all the tools that have tests? But might be to much work. Up to you.
Thanks for the review @bernt-matthias 👍 I was thinking of opening another PR where I bump the version of all tools and work -hopefully collaboratively- on updating the other tools there. But I would like to get needleall in a bit sooner if possible, so doing that first. |
Another thing that makes it more complicated is that those tools are not a Suite. Once we push we change all tools. Should we break tool linage here and fix also the tool IDs? |
@bgruening sure, I can do that |
Then we would have 2 of each tool (or at least those where we would change the ID) in the tool panel. Would not like this. |
Yes I also don't like it :( Admins need to install those (new) tools manually either way and with that, they could "hide" the old versions. On the other hand, workflows will not be as easy to update. @galaxyproject/iuc any opinions. |
Added the
needleall
tool to the emboss suite. This tool is new in version 6. Since theneedle
tool is extremely similar I bumped its version as well and added some additional parameters.I hope to be able to upgrade some of the other tools as well in the future. For reference, these are the most popular emboss tools on EU (thanks @bgruening!), so we can prioritize these for a version bump.
ping also @bernt-matthias since we chatted about this
FOR CONTRIBUTOR: