Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new tool] ETE treeview #6614

Merged
merged 26 commits into from
Dec 10, 2024
Merged

[new tool] ETE treeview #6614

merged 26 commits into from
Dec 10, 2024

Conversation

shiltemann
Copy link
Member

Implements ETE-toolkit's Phylogenetic tree (newick) viewer tool, available as a web service here: http://etetoolkit.org/treeview/

FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)

tools/ete-toolkit/ete-treeviewer.xml Outdated Show resolved Hide resolved
tools/ete-toolkit/.shed.yml Outdated Show resolved Hide resolved
@bernt-matthias
Copy link
Contributor

Is the source code of the website available? Can we do this with https://github.com/TGAC/earlham-galaxytools/tree/master/tools/ete?

@shiltemann
Copy link
Member Author

Hi @bernt-matthias the code unfortunately is not on the etetoolkit github. I did write the authors to ask for the code but no response. If/when I do get that code I would be happy to update the tool to use that instead of the web service

@bgruening bgruening closed this Dec 9, 2024
@bgruening bgruening reopened this Dec 9, 2024
Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if you like the two suggestions please apply and then ready for merge :)

Thanks @shiltemann

tools/ete-toolkit/ete-treeviewer.xml Outdated Show resolved Hide resolved
tools/ete-toolkit/ete-treeviewer.xml Outdated Show resolved Hide resolved
tools/ete-toolkit/.shed.yml Outdated Show resolved Hide resolved
Co-authored-by: Björn Grüning <[email protected]>
@bgruening
Copy link
Member

I tried different font packages, and graphicsmagick ... pff ... I hope this now works.

@bgruening bgruening closed this Dec 10, 2024
@bgruening bgruening reopened this Dec 10, 2024
@bgruening bgruening merged commit d2208e8 into galaxyproject:main Dec 10, 2024
17 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants