Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding HalfDeep #6592

Merged
merged 13 commits into from
Dec 5, 2024
Merged

adding HalfDeep #6592

merged 13 commits into from
Dec 5, 2024

Conversation

richard-burhans
Copy link
Contributor

adding HalfDeep

FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)

bgruening
bgruening reviewed Nov 27, 2024
View reviewed changes
tools/halfdeep/halfdeep.xml Outdated Show resolved Hide resolved
tools/halfdeep/halfdeep.xml Outdated Show resolved Hide resolved
bernt-matthias
bernt-matthias reviewed Nov 27, 2024
View reviewed changes
Copy link
Contributor

@bernt-matthias bernt-matthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really sure what the tool does. Would be great if this could be better explained.

Half depth of what?

tools/halfdeep/halfdeep.xml Outdated Show resolved Hide resolved
tools/halfdeep/halfdeep.xml Outdated Show resolved Hide resolved
@richard-burhans
Copy link
Contributor Author

@bgruening @bernt-matthias This is ready to be reviewed again.

bernt-matthias
bernt-matthias reviewed Dec 3, 2024
View reviewed changes
tools/halfdeep/halfdeep.xml Outdated Show resolved Hide resolved
tools/halfdeep/halfdeep.xml Outdated Show resolved Hide resolved
tools/halfdeep/halfdeep.xml Outdated Show resolved Hide resolved
@richard-burhans
Copy link
Contributor Author

@bgruening @bernt-matthias The HalfDeep tool is ready to be reviewed again.

bgruening
bgruening approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @richard-burhans

@bgruening bgruening merged commit 63179f3 into galaxyproject:main Dec 5, 2024
11 checks passed
@richard-burhans richard-burhans deleted the add-halfdeep branch December 5, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bernt-matthias bernt-matthias bernt-matthias left review comments

@bgruening bgruening bgruening approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@richard-burhans @bgruening @bernt-matthias