Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tool update] Trimal #6577

Merged
merged 22 commits into from
Nov 20, 2024
Merged

[tool update] Trimal #6577

merged 22 commits into from
Nov 20, 2024

Conversation

shiltemann
Copy link
Member

@shiltemann shiltemann commented Nov 20, 2024

Update wrapper for Trimal, a tool for trimming multiple alignment files.

Added some more parameters and small tweaks

Part of a larger effort to create a gene family tree pipeline

FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)

@shiltemann
Copy link
Member Author

oh! guess I just missed #6397 by @B0r1sD

@bgruening
Copy link
Member

@shiltemann
Copy link
Member Author

cool, I will rebase and see if there is anything I have in my version that can enhance the current wrapper or not

@shiltemann shiltemann changed the title [New Tool] Trimal [tool update] Trimal Nov 20, 2024
tools/trimal/trimal.xml Outdated Show resolved Hide resolved
Co-authored-by: Björn Grüning <[email protected]>
tools/trimal/trimal.xml Outdated Show resolved Hide resolved
@bgruening bgruening merged commit f657597 into galaxyproject:main Nov 20, 2024
11 checks passed
@shiltemann
Copy link
Member Author

Thanks for the fixes @bgruening!

@B0r1sD
Copy link
Contributor

B0r1sD commented Nov 21, 2024

Seems like enhancements were definitely made, thanks @shiltemann!
Ping @nicodr97 and @pauldg for visibility.

@nicodr97
Copy link
Contributor

Wonderful! Would it make sense to remove the html output by default? Or at least the possibility for the user not to generate it? Thank you for the contributions :)

@shiltemann
Copy link
Member Author

@nicodr97 sure, we can make that choice for users if you think that is useful 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants