Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SnpEff: distinguish between tool version and internal snpeff version … #6572

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

wm75
Copy link
Contributor

@wm75 wm75 commented Nov 18, 2024

…string

FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)

@wm75 wm75 requested a review from nsoranzo as a code owner November 18, 2024 21:22
@wm75
Copy link
Contributor Author

wm75 commented Nov 18, 2024

should fix #6571

No version bump because it seems reasonable to mask the broken version.

@bgruening @nsoranzo review welcome :-)

@wm75
Copy link
Contributor Author

wm75 commented Nov 18, 2024

The issue is that SnpEff databases state their version in the metadata like this:
image

so validating against the tool version makes no sense.

@nsoranzo
Copy link
Member

@bgruening bgruening merged commit 280d524 into galaxyproject:main Nov 18, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants