Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linter fixes for fasttree #6389

Merged
merged 2 commits into from
Oct 5, 2024

Conversation

bernt-matthias
Copy link
Contributor

Leaving the InputsBoolDistinctValues skip: the boolean has no truevalue and falsevalue. It's used in a filter and an if statement of the command block .. and this works.

FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)

@bgruening bgruening merged commit 54cc705 into galaxyproject:main Oct 5, 2024
11 checks passed
@mvdbeek
Copy link
Member

mvdbeek commented Oct 5, 2024

Attention: deployment failure!

https://github.com/galaxyproject/tools-iuc/actions/runs/11192302077

@mvdbeek
Copy link
Member

mvdbeek commented Dec 16, 2024

Leaving the InputsBoolDistinctValues skip: the boolean has no truevalue and falsevalue. It's used in a filter and an if statement of the command block .. and this works.

How can this work ? https://github.com/mvdbeek/galaxy/blob/user_defined_tools/lib/galaxy/tool_util/parser/util.py#L72-L86
This should be a linting error on profile >= 23.1. The tool doesn't even parse, so no tests were run.

@mvdbeek mvdbeek mentioned this pull request Dec 16, 2024
5 tasks
@bernt-matthias bernt-matthias deleted the linter-fasttree branch December 16, 2024 09:46
@bernt-matthias
Copy link
Contributor Author

Do you see a possibility to make the test fail if the tool fails to load?

@mvdbeek
Copy link
Member

mvdbeek commented Dec 16, 2024

Maybe, the parser lives in tool-util ? This is covered by the linter, we should just not disable it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants