Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metabologram fix (dimet tool) #6210

Merged
merged 6 commits into from
Aug 6, 2024
Merged

Conversation

johaGL
Copy link
Contributor

@johaGL johaGL commented Aug 5, 2024

FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)

This PR solves issue #6208

@johaGL
Copy link
Contributor Author

johaGL commented Aug 6, 2024

please check why planemo lint fails @johaGL

@bgruening
Copy link
Member

.. WARNING (HelpInvalidRST): Invalid reStructuredText found in help - [:159: (WARNING/2) Bullet list ends without a blank line; unexpected unindent.

@bgruening
Copy link
Member

If you are using https://github.com/galaxyproject/galaxy-language-server then it might show you the error.

@johaGL
Copy link
Contributor Author

johaGL commented Aug 6, 2024

thank you @bgruening with your help I found it :), and solved it. Hope the other tests will pass (even if from my side planemo test was ok).

Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump the VERSION_SUFFIX number and you might want to update the citation as well.

@johaGL
Copy link
Contributor Author

johaGL commented Aug 6, 2024

Please bump the VERSION_SUFFIX number and you might want to update the citation as well.

thank you a lot, yes now it is done :)

@johaGL
Copy link
Contributor Author

johaGL commented Aug 6, 2024

thank you a lot for revisions and suggestions @bgruening , from our side we are done :)

tools/dimet/macros.xml Outdated Show resolved Hide resolved
@johaGL
Copy link
Contributor Author

johaGL commented Aug 6, 2024

thanks! now much better with just doi :)

@bgruening bgruening merged commit 6da96d8 into galaxyproject:main Aug 6, 2024
14 checks passed
nilchia pushed a commit to pavanvidem/tools-iuc that referenced this pull request Aug 24, 2024
* update(metabologram): add user output option 'show_values' to write the values in the plots or not

* metabologram: deleted metabolites selector as is not pertinent

* input explanation: only abundances and mean enrichment accepted; improved Help text

* metabologram: lint error solved, also more improvement of Help

* update macros dimet: citation and suffix version; also for differential analysis improved Help

* Update tools/dimet/macros.xml

---------

Co-authored-by: Björn Grüning <[email protected]>
@johaGL johaGL changed the title Metabologram fix Metabologram fix (dimet tool) Sep 3, 2024
@johaGL johaGL deleted the metabologram-fix branch September 4, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants