Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Cami Opal - A tool for evaluating taxonomic metagenome profilers #6096

Open
wants to merge 32 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
33a53eb
Added the profile2cami tool, a component of the TaxonKit suite.
ber58 Jun 14, 2024
461a8a7
Renamed shed.yml -> .shed.yml
ber58 Jun 14, 2024
3db4745
Shrinked delnodes.dmp 684kb -> 150kb
ber58 Jun 17, 2024
d15df70
Renamed test.loc -> ncbi_taxonomy.loc
ber58 Jun 17, 2024
a09b364
Added the cami OPAl tool.
ber58 Jun 19, 2024
fbd0a54
Removed large files from test-data
ber58 Jun 19, 2024
5a195bb
Cleaned up test-data, modified test in cami_opal.xml.
ber58 Jun 19, 2024
d462694
renamed shed.yml -> .shed.yml
ber58 Jun 19, 2024
0f22502
fixed linting errors
ber58 Jun 19, 2024
15dea3a
Merge branch 'galaxyproject:main' into feature-cami_opal
ber58 Jun 24, 2024
047becc
Adjusted, issues from PR for opal
ber58 Jun 24, 2024
a7d5b4b
Removed taxonkit, from the cami-opal PR
ber58 Jun 24, 2024
060f3bf
Exchanged .shed.yml with the right one
ber58 Jun 24, 2024
fde7a42
Fixed the tests, worked on issues, cleaned up the code
ber58 Jun 24, 2024
f01b119
Some cleaning up...
ber58 Jun 24, 2024
be596e9
Merge branch 'galaxyproject:main' into feature-cami_opal
ber58 Jul 3, 2024
75cb130
Worked on issues regarding opal.xml
ber58 Jul 3, 2024
d984487
collection output
paulzierep Jul 9, 2024
f40b015
Merge pull request #2 from paulzierep/feature-cami_opal
ber58 Jul 9, 2024
76a72b1
Removed gzip option, renamed campi-opal to cami_opal to match cami_amber
ber58 Jul 9, 2024
ae15a9a
Worked on implementing collection output, integrated new tests, label…
ber58 Jul 10, 2024
d21db03
Removed unnecessary files from cami_opal
ber58 Jul 11, 2024
edd2a57
Adjusted shed.yml
ber58 Jul 30, 2024
21ef9db
Adjusted the help label, mentioned profile2cami to make it easier for…
ber58 Jul 30, 2024
080c7a3
Worked on Opal issues
ber58 Jul 30, 2024
e708085
Created a test to check normalization, adjusted the filter option
ber58 Aug 5, 2024
4361fe2
Reset Version to 1.0.12
ber58 Aug 5, 2024
db4cc5c
Merge branch 'galaxyproject:main' into feature-cami_opal
ber58 Aug 13, 2024
c7a4d49
Added biotools, removed extra info from help section
ber58 Aug 15, 2024
7e05dd0
Added right biotools ref
ber58 Aug 15, 2024
7146070
Changed Discription
ber58 Oct 19, 2024
8cffbbb
Fixed issues mentioned by bgruening
ber58 Oct 20, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 30 additions & 16 deletions tools/cami_opal/cami_opal.xml
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,6 @@
'inputs/${safe_identifier}'
#end for

## #for $input_file in $input_files:
## #set safe_identifier = re.sub('[^\w\-\.]', '_', $input_file.file.element_identifier)
## 'inputs/${safe_identifier}'
## #end for

#set $sep = ''
ber58 marked this conversation as resolved.
Show resolved Hide resolved
-l
'
Expand Down Expand Up @@ -96,7 +91,7 @@
label="Normalize samples"
help="Normalize the samples to compare them on the same scale."
ber58 marked this conversation as resolved.
Show resolved Hide resolved
truevalue="-n" falsevalue="" />
<param argument="--filter" type="integer" value="0" optional="true"
<param argument="--filter" type="float" value="0" optional="true"
label="Filter out predictions with the smallest relative abundances summing up to this percentage within a rank"
help="This parameter allows you to filter out the predictions with the smallest relative abundances, such that their cumulative sum is equal to the specified percentage within a taxonomic rank. The value should be between 0 and 100."
min="0" max="100" />
Expand Down Expand Up @@ -147,13 +142,13 @@
<filter>html_output</filter>
</data>
<data name="result" format="tabular" from_work_dir="output/results.tsv" label="${tool.name} on ${on_string}: Results" />
<collection name="rank_output" type="list" label="${tool.name}: Rank tables" format="tabular" >
<collection name="rank_output" type="list" label="${tool.name}: Rank tables" >
<filter>output_collections</filter>
<discover_datasets pattern="(?P&lt;designation&gt;.+)\.tsv" directory="output/by_rank"/>
<discover_datasets pattern="(?P&lt;designation&gt;.+)\.tsv" directory="output/by_rank" format="tabular"/>
</collection>
<collection name="tool_output" type="list" label="${tool.name}: Tool tables" format="tabular">
<collection name="tool_output" type="list" label="${tool.name}: Tool tables" >
<filter>output_collections</filter>
<discover_datasets pattern="(?P&lt;designation&gt;.+)\.tsv" directory="output/by_tool/"/>
<discover_datasets pattern="(?P&lt;designation&gt;.+)\.tsv" directory="output/by_tool/" format="tabular"/>
</collection>
</outputs>
<tests>
Expand Down Expand Up @@ -194,7 +189,7 @@
<param name="normalize" value="true"/>
<param name="filter" value="5"/>
<param name="plot_abundances" value="true"/>
<param name="desc" value="Detailed test description for OPAL"/>
<param name="desc" value="Test description for OPAL"/>
<param name="ranks" value="superkingdom,species"/>
<param name="metrics_plot_rel" value="w,l,c,p,f,t"/>
<param name="metrics_plot_abs" value="c,p,b"/>
Expand All @@ -204,7 +199,7 @@
<param name="output_collections" value="true"/>
<output name="htmlreport" ftype="html">
<assert_contents>
<has_text text="Detailed test description for OPAL" />
<has_text text="Test description for OPAL" />
</assert_contents>
</output>
<output name="result" ftype="tabular">
Expand All @@ -224,7 +219,7 @@
<param name="normalize" value="true"/>
<param name="filter" value="5"/>
<param name="plot_abundances" value="true"/>
<param name="desc" value="Detailed test description for OPAL"/>
<param name="desc" value="Test description for OPAL"/>
<param name="ranks" value="superkingdom,species"/>
<param name="metrics_plot_rel" value="w,l,c,p,f,t"/>
<param name="metrics_plot_abs" value="c,p,b"/>
Expand All @@ -234,7 +229,7 @@
<param name="output_collections" value="false"/>
<output name="htmlreport" ftype="html">
<assert_contents>
<has_text text="Detailed test description for OPAL" />
<has_text text="Test description for OPAL" />
</assert_contents>
</output>
<output name="result" ftype="tabular">
Expand All @@ -246,6 +241,25 @@
</assert_contents>
</output>
</test>
<!-- Test with normalization enabled -->
<test expect_num_outputs="1">
<param name="gold_standard_file" value="gs_test.profile" />
<param name="input_files" value="kraken_test.profile" />
<param name="normalize" value="true"/>
<param name="html_output" value="false"/>
<param name="output_collections" value="false"/>
<output name="result" ftype="tabular" file="normalized_k.tsv" lines_diff="30" />
</test>

<!-- Test with normalization disabled -->
<test expect_num_outputs="1">
<param name="gold_standard_file" value="gs_test.profile" />
<param name="input_files" value="kraken_test.profile" />
<param name="normalize" value="false"/>
<param name="html_output" value="false"/>
<param name="output_collections" value="false"/>
<output name="result" ftype="tabular" file="not_normalized_k.tsv" lines_diff="30" />
</test>
</tests>
<help>
<![CDATA[
Expand All @@ -269,10 +283,10 @@
OPAL requires the following inputs:

1. **Gold Standard File**
- This file is essential for the evaluation and should be in BIOM format.
- This file is essential for the evaluation and should be CAMI Profiling Bioboxes format.

2. **Profiles Files**
- Multiple profile files are required for evaluation. These files should be in CAMI Profiling Bioboxes format or BIOM format. If your files are not in the required format, you can use the `profile2cami` tool to convert them to the CAMI Profiling format.
- Multiple profile files are required for evaluation. If your files are not in the required format, you can use the `profile2cami` tool to convert them to the CAMI Profiling format.

**Outputs**

Expand Down
2 changes: 1 addition & 1 deletion tools/cami_opal/macros.xml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<yield/>
</requirements>
</xml>
<token name="@TOOL_VERSION@">1.0.12</token>
ber58 marked this conversation as resolved.
Show resolved Hide resolved
<token name="@TOOL_VERSION@">1.0.12-1</token>
<token name="@VERSION_SUFFIX@">0</token>
<token name="@PROFILE@">21.05</token>
<xml name="citations">
Expand Down
Loading
Loading