Skip to content

Commit

Permalink
Maxbin2 - removing whitespaces from reads filename to fix bug (#5688)
Browse files Browse the repository at this point in the history
* removing spaces from reads filenames to fix bug

* changed test file to smaller file

* undone changes that should not have occured
  • Loading branch information
Ralwoss authored Dec 20, 2023
1 parent 4b95b96 commit be3f3d0
Show file tree
Hide file tree
Showing 2 changed files with 1,982 additions and 2 deletions.
36 changes: 34 additions & 2 deletions tools/maxbin2/maxbin2.xml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<tool id="maxbin2" name="MaxBin2" version="@MAXBIN_VERSION@+galaxy4">
<tool id="maxbin2" name="MaxBin2" version="@MAXBIN_VERSION@+galaxy5">
<description>clusters metagenomic contigs into bins</description>
<macros>
<token name="@MAXBIN_VERSION@">2.2.7</token>
Expand Down Expand Up @@ -30,7 +30,7 @@
#if $assembly.type == 'individual'
## uncompress .gz reads files if necessary
#set $e = $assembly.inputs.reads
#set $identifier = re.sub('[^\s\w\-\\.]', '_', str($e.element_identifier))
#set $identifier = re.sub('[^\w\-\\.]', '_', str($e.element_identifier))
#if $e.ext.endswith(".gz")
gunzip -c '$e' > '$identifier' &&
echo '$identifier' >> reads_list &&
Expand Down Expand Up @@ -394,6 +394,38 @@ run_MaxBin.pl
<output name="noclass" file="4/out.noclass" ftype="fasta" />
<output name="toshort" file="4/out.tooshort" ftype="fasta" />
</test>
<!-- test w contigs and reads in fastqsanger format as input (and whitespace in reads filename)-->
<test expect_num_outputs="4">
<param name="contig" value="test4_contigs.fasta" ftype="fasta" />
<conditional name="assembly">
<param name="type" value="individual"/>
<conditional name="inputs">
<param name="type" value="reads"/>
<param name="reads" value="test4_reads 2.fastqsanger" ftype="fastqsanger"/>
<param name="output_abundances" value="false"/>
<param name="reassembly" value=""/>
</conditional>
</conditional>
<section name="adv">
<param name="min_contig_length" value="1000"/>
<param name="max_iteration" value="50"/>
<param name="prob_threshold" value="0.5"/>
</section>
<section name="output">
<param name="plotmarker" value=""/>
<param name="marker" value="false"/>
<param name="markers" value="false" />
<param name="log" value="false"/>
<param name="markerset" value="107"/>
</section>
<output_collection name="bins" type="list" count="2">
<element name="001" file="4/out.001.fasta" ftype="fasta"/>
<element name="002" file="4/out.002.fasta" ftype="fasta"/>
</output_collection>
<output name="summary" file="4/out.summary" ftype="tabular" />
<output name="noclass" file="4/out.noclass" ftype="fasta" />
<output name="toshort" file="4/out.tooshort" ftype="fasta" />
</test>
<!-- test w contigs and reads in fastqsanger.gz format as input -->
<test expect_num_outputs="4">
<param name="contig" value="test4_contigs.fasta" ftype="fasta" />
Expand Down
Loading

0 comments on commit be3f3d0

Please sign in to comment.