Do not attempt to complete pre- or post-process if jobs are cancelled in the middle of either stage #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the middle of either stage.
mvdbeek
approved these changes
May 1, 2024
|
Thanks @natefoo, should I cut a new release ? |
|
No, I'm deploying from git to JS2 right now, and will have more things coming. THanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly fixes #364. Ideally we would also interrupt any running transfers since those could be exceptionally long running and wasteful, but doing so requires interrupting a thread running a non-looping action.
We are probably better off moving those to more properly managed asynchronous tasks (celery, multiprocessing, etc.).
EDIT: Also fixes #353, although not by caring whether it's a 403.