Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to pass extra arguments to docker run #1428

Merged

Conversation

bernt-matthias
Copy link
Contributor

I have a usecase where I want to test a tool that uses another server running in CI as container. In order to allow be able to access the host's localhost I need to pass --add-host=host.docker.internal:host-gateway to docker run (at least I do not know of another way).

Copy link
Member

@mvdbeek mvdbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

Co-authored-by: Marius van den Beek <[email protected]>
@bernt-matthias
Copy link
Contributor Author

Just trying to use this branch over here Helmholtz-UFZ/galaxy-tools#17.

@mvdbeek
Copy link
Member

mvdbeek commented Feb 8, 2024

Seems to have worked ?

@mvdbeek mvdbeek merged commit e69487c into galaxyproject:master Feb 8, 2024
14 checks passed
@bernt-matthias bernt-matthias deleted the topic/docker-extra-args branch February 8, 2024 14:45
@bernt-matthias
Copy link
Contributor Author

Seems to have worked ?

Yep :)

@mvdbeek
Copy link
Member

mvdbeek commented Feb 8, 2024

New release ?

@bernt-matthias
Copy link
Contributor Author

Would be nice, because cleaner in the CI over there (currently I install from a branch).

@mvdbeek
Copy link
Member

mvdbeek commented Feb 8, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants