Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stuck colormode in website #623

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

dannon
Copy link
Member

@dannon dannon commented Dec 5, 2024

If someone happened to visit iwc.galaxyproject.org with dark mode enabled prior to us swapping to a galaxy-themed light mode by default, the browser could get stuck in dark mode due to the way nuxt stores a key in local storage without unsetting it. This is a workaround that unsticks the stuck mode.

FOR CONTRIBUTOR:

  • I have read the Adding workflows guidelines
  • License permits unrestricted use (educational + commercial)
  • Please also take note of the reviewer guidelines below to facilitate a smooth review process.

FOR REVIEWERS:

  • .dockstore.yml: file is present and aligned with creator metadata in workflow. ORCID identifiers are strongly encouraged in creator metadata. The .dockstore.yml file is required to run tests
  • In workflow: annotation field contains short description of what the workflow does. Should start with This workflow does/runs/performs … xyz … to generate/analyze/etc …
  • In workflow: workflow inputs and outputs have human readable names (spaces are fine, no underscore, dash only where spelling dictates it), no abbreviation unless it is generally understood. Altering input or output labels requires adjusting these labels in the the workflow-tests.yml file as well
  • In workflow: name field should be human readable (spaces are fine, no underscore, dash only where spelling dictates it), no abbreviation unless generally understood
  • Workflow folder: prefer dash (-) over underscore (_), prefer all lowercase. Folder becomes repository in iwc-workflows organization and is included in TRS id
  • Readme explains what workflow does, what are valid inputs and what outputs users can expect. If a tutorial or other resources exist they can be linked. If a similar workflow exists in IWC readme should explain differences with existing workflow and when one might prefer one workflow over another
  • Changelog contains appropriate entries
  • Large files (> 100 KB) are uploaded to zenodo and location urls are used in test file

@dannon dannon changed the title Fix stuck colormode Fix stuck colormode in website Dec 5, 2024
@dannon
Copy link
Member Author

dannon commented Dec 5, 2024

We can ignore the failing build preview here -- that's also on my list for today to approach in a different way (the publish will work fine -- it's just the preview that can't happen from forks due to permissions)

@mvdbeek mvdbeek merged commit 490160d into galaxyproject:main Dec 6, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants