-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
first release of RNAseq DE analysis, filtering and plotting workflow #582
Conversation
👍 This looks good. |
Maybe you should write in the directory or in the workflow is only for 2 conditions. |
sure! I will write in the workflow description |
One of my colleague proposed that the input could be a single collection and a replicate assignment like 1,1,1,2,2,2 and a batch assignment like 1,2,3,1,2,3. I don't know if this makes sense or a samples plan like @wm75 proposed in #581 (with less columns).
|
replicate assignments are fine because we know there are exactly 2 conditions. But I don't think it is possible to include batches unless we assume there are fixed number of batches. Where should we use these batches information? in multi-factor analysis? |
I think we would need to rewrite the wrapper to allow to set the batches dynamically in workflows so this is just for future development. |
just simple two-conditions comparison might be good enough for this version. |
can you arrange the inputs in a more meaningful way @pavanvidem ? |
Also 0.0 doesn't seem like a good default for neither of the thresholds. |
I think this version is fine. I just say that to make this more usable we should think about developing workflows to split the count collection into 2 (in another PR). |
These are non-optional parameters of tools. I can only set a default if I make then optional and I have to use the dirty trick of connecting the steps and then making them optional with defaults :) |
The "better" trick is to use pick value after the optional param and if it's not set, pick the default value again :-) |
For me, 'Main factor counts' and 'Base factor counts' are not really meaningful. |
Why don't we simply put it optional with a default value? |
sounds better! I will change |
Yes, the factor and factor levels should have better names. Alternatively, you could also use input params there. |
If a tool has this param as non-optional. If we set this to optional, we cannot connect this value to the tool. |
|
I am also building another 2 workflows (a paired and a single) in the same directory which will combine the quantification workflow and this one so that we will have complete DESeq2 workflows. But this PR can be merged before I add them. |
workflows/transcriptomics/rnaseq-de/rnaseq-de-filtering-plotting.ga
Outdated
Show resolved
Hide resolved
Would you mind to remove the test-data? |
sure, forgot :) |
Test Results (powered by Planemo)Test Summary
Passed Tests
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thank you so much.
@mvdbeek you want to review?
This workflow is downstream analysis of the existing rnaseq-pe and rnaseq-sr workflows. It takes 2 collections and performs differential expressin analysis, annotates the results table, filters and generates a valcano plot, a z-scores heatmap and a heatmap of normalized counts.