Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent negative offset #19409

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Prevent negative offset #19409

merged 1 commit into from
Jan 16, 2025
+4 −4

Conversation

jdavcs
Copy link
Member

@jdavcs jdavcs commented Jan 15, 2025

Follow-up to #19090

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@jdavcs jdavcs added this to the 25.0 milestone Jan 15, 2025
martenson
martenson approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@martenson martenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the followup @jdavcs !

@martenson martenson merged commit 4e781cd into galaxyproject:dev Jan 16, 2025
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martenson martenson martenson approved these changes

Assignees
No one assigned
Labels
area/UI-UX kind/bug
Projects
None yet
Milestone
25.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jdavcs @martenson