Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.0] Remove unnecessary quoting in conda package specification #19382

Merged

Conversation

nsoranzo
Copy link
Member

@nsoranzo nsoranzo commented Jan 7, 2025

Fix the following error in:

  • test/unit/tool_util/test_conda_resolution.py::test_install_conda_build
  • test/integration/test_resolvers.py::TestCondaResolutionIntegration::test_dependency_install
  • test/integration/test_resolvers.py::TestCondaResolutionIntegration::test_uninstall_through_tools_api
InvalidMatchSpec: Invalid spec ''pyopenssl>=22.1.0'': Invalid version '22.1.0'': invalid character(s)

This probably started happening with a recent conda update.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Fix the following error in:
- test/unit/tool_util/test_conda_resolution.py::test_install_conda_build
- test/integration/test_resolvers.py::TestCondaResolutionIntegration::test_dependency_install
- test/integration/test_resolvers.py::TestCondaResolutionIntegration::test_uninstall_through_tools_api

```
InvalidMatchSpec: Invalid spec ''pyopenssl>=22.1.0'': Invalid version '22.1.0'': invalid character(s)
```
@nsoranzo
Copy link
Member Author

nsoranzo commented Jan 7, 2025

Test failures unrelated.

@jmchilton jmchilton merged commit 7fd1b6a into galaxyproject:release_24.0 Jan 7, 2025
42 of 52 checks passed
@nsoranzo nsoranzo deleted the release_24.0_pkg_spec_quoting branch January 7, 2025 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants