Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.2] Fixes for console logging. #19381

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

jmchilton
Copy link
Member

Only poll for async console updates while job is running.

How to test the changes?

(Select all options that apply)

  • Instructions for manual testing are as follows:
    1. Enable the feature - setup a silly tool that sleeps and outputs randomly - watch the developer console while on the job info page for that tool. Note it still updates while running but doesn't make that call if it is not running.

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Copy link
Member

@mvdbeek mvdbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed a fix for the test error, still draft @jmchilton ?

@jmchilton jmchilton marked this pull request as ready for review January 9, 2025 14:44
@github-actions github-actions bot added this to the 25.0 milestone Jan 9, 2025
@jmchilton
Copy link
Member Author

Thanks for the fix to the fix @mvdbeek!

@mvdbeek mvdbeek merged commit 3c9f126 into galaxyproject:release_24.2 Jan 9, 2025
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants