[24.2] Fix to not display upload when creating collections from existing datasets. #19373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmchilton
added
kind/bug
kind/enhancement
area/UI-UX
kind/refactoring
jmchilton
force-pushed
the
upload_tab_optional
branch
from
0f38d54 to
b2e2053
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think the dialog option makes sense in that context and it consumes a lot of space. I love the feature overall and it makes perfect sense in the upload modal or when on the tool form and you don't have datasets in the history or you want to add new ones. But having the tab even when you've just selected some history contents or library contents I think feels off. There is a few refactorings of things to prevent a huge copy and paste inside and outside the tab component for this. There might be a better way to make tabbing optional - I'd be happy to hear it but these are still good refactorings I think (just not ideal for a bug fix on a stable release).
How to test the changes?
(Select all options that apply)
License