Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access public history in job cache / job search #19108

Merged

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Nov 5, 2024

I think this is ready, but maybe want to make it configurable on the user side if we want to pick up public results ?

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@mvdbeek mvdbeek changed the title Access public history in job cache Access public history in job cache / job search Nov 5, 2024
Copy link
Member

@jdavcs jdavcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. SQLite fix makes sense.
Thanks!

Ready to move out of draft?

lib/galaxy/schema/jobs.py Outdated Show resolved Hide resolved
lib/galaxy_test/base/api.py Outdated Show resolved Hide resolved
lib/galaxy_test/base/api.py Outdated Show resolved Hide resolved
@mvdbeek mvdbeek force-pushed the access_public_history_in_job_cache branch from 717eb97 to 360b72a Compare November 6, 2024 10:43
@mvdbeek mvdbeek marked this pull request as ready for review November 6, 2024 10:44
@mvdbeek mvdbeek mentioned this pull request Nov 6, 2024
4 tasks
@github-actions github-actions bot added this to the 24.2 milestone Nov 6, 2024
Copy link
Member

@nsoranzo nsoranzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks!

@bgruening
Copy link
Member

🎉

@mvdbeek mvdbeek merged commit d07b528 into galaxyproject:dev Nov 6, 2024
58 checks passed
@nsoranzo nsoranzo deleted the access_public_history_in_job_cache branch November 6, 2024 14:12
@jmchilton
Copy link
Member

This seems like it really needs to be accompanied with some sort of tool syntax that declares the tool depends on the user running the job 😓.

@mvdbeek
Copy link
Member Author

mvdbeek commented Nov 7, 2024

I haven't understood the link here, what would the tool annotation say ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants