Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence the quota manager for updates #19046

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

bernt-matthias
Copy link
Contributor

@bernt-matthias bernt-matthias commented Oct 23, 2024

this should make the quota manager a bit more silent when updating quotas, i.e. only message when something is changed

In #18775 (comment) it was suggested to remove all messages, but I find it quite useful when using bioblend. But I'm happy to remove them all and compute a diff of the old and new quota ... ?

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@bernt-matthias bernt-matthias marked this pull request as draft October 23, 2024 17:29
@github-actions github-actions bot added this to the 24.2 milestone Oct 23, 2024
@bernt-matthias bernt-matthias force-pushed the silence-quota-manager branch 2 times, most recently from 3792ffa to 2d89dd0 Compare October 23, 2024 19:16
this should make the quota manager a bit more siltent when
updating quotas, i.e. only message when something is changed

In galaxyproject#18775 (comment)
it was suggested to remove all messages, but I find it quite useful
when using bioblend.
@bernt-matthias bernt-matthias marked this pull request as ready for review November 6, 2024 09:17
Copy link
Member

@jdavcs jdavcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@jdavcs jdavcs merged commit 7f513fd into galaxyproject:dev Nov 12, 2024
53 of 54 checks passed
Copy link

This PR was merged without a "kind/" label, please correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants