Place invocation state in list #17708
Conversation
|
I have also added modifications to the Summary tab here: #17413, which will work nicely with these changes! |
jmchilton
force-pushed
the
place_state_in_invocation_list
branch
from
00de142 to
ec403cc
Compare
jmchilton
force-pushed
the
place_state_in_invocation_list
branch
from
b47999a to
31d9b48
Compare
|
Errors seem related - might close this out and get smaller pieces merged first to narrow things down. |
jmchilton
force-pushed
the
place_state_in_invocation_list
branch
from
31d9b48 to
1f0731e
Compare
|
@ahmedhamidawan I stopped working on this because I thought your work superseded it but @mvdbeek mentioned maybe this was still useful. If that is the case, let me know and I can try to rebase it against your latest work or alternatively feel free to pull the bits and pieces of out of this that are useful if any of them are. |
|
This is waiting on #18615 |
ahmedhamidawan
force-pushed
the
place_state_in_invocation_list
branch
from
1f0731e to
b06cc8e
Compare
ahmedhamidawan
force-pushed
the
place_state_in_invocation_list
branch
from
b06cc8e to
bb96e84
Compare
for the invocation graph view
| @@ -169,7 +173,7 @@ export function useInvocationGraph( | |||
| invocationStepSummary = stepsJobsSummary.find((stepJobSummary: StepJobSummary) => { | |||
| if (stepJobSummary.model === "ImplicitCollectionJobs") { | |||
| return stepJobSummary.id === invocationStep.implicit_collection_jobs_id; | |||
| } else { | |||
| } else if (stepJobSummary.model === "Job") { | |||
| return stepJobSummary.id === invocationStep.job_id; | |||
There was a problem hiding this comment.
@jmchilton As you can see in this 78f653c commit, I needed to use LegacyWorkflowInvocationElementView because right here, we need the job_id to associate the stepJobSummary with it.
Of course, overall, I need to rebase and readjust these changes, but is this the right approach as far as the view is concerned?
The actual invocation state we decided wasn't very useful at the team meeting. Foregrounding the progress bars is a potential improvement. I've done some query optimization for this.
Screen.Recording.2024-03-13.at.5.20.19.PM.mov
How to test the changes?
(Select all options that apply)
License