Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert historyItemsStore to ts+composition #16873

Merged
merged 3 commits into from
Oct 25, 2023
Merged

Convert historyItemsStore to ts+composition #16873

merged 3 commits into from
Oct 25, 2023

Conversation

ahmedhamidawan
Copy link
Member

@ahmedhamidawan ahmedhamidawan commented Oct 18, 2023 •
edited
Loading

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 23.2 milestone Oct 18, 2023
@davelopez
Copy link
Contributor

Since this is a bug fix shouldn't it target 23.1?

@ahmedhamidawan
Copy link
Member Author

ahmedhamidawan commented Oct 19, 2023 •
edited
Loading

Since this is a bug fix shouldn't it target 23.1?

Separated the bug fix into #16889 which targets 23.1

@ahmedhamidawan ahmedhamidawan changed the title Fix HistoryPanel filter reactivity with deletions/undeletions, and convert historyItemsStore to ts+composition Convert historyItemsStore to ts+composition Oct 19, 2023
@ahmedhamidawan ahmedhamidawan added kind/refactoring cleanup or refactoring of existing code, no functional changes and removed kind/bug labels Oct 19, 2023
@davelopez davelopez mentioned this pull request Oct 20, 2023
Merged
4 tasks
@ahmedhamidawan ahmedhamidawan force-pushed the history_items_filtering_reactivity_bug branch from 39cd6b3 to d67f859 Compare October 23, 2023 22:37
@ahmedhamidawan
Convert historyItemsStore to ts+composition
af7b6f4 
Also, set `loading` bool to true for async History operations
in panel
@ahmedhamidawan
fix wordMatches array for ToolSearch
9d248c3 
make sure, it is a Set (no duplicate matches)
@ahmedhamidawan ahmedhamidawan force-pushed the history_items_filtering_reactivity_bug branch from d67f859 to 9d248c3 Compare October 23, 2023 23:02
@ahmedhamidawan
change then/catch into try/catch
4439afa 
remove `Ref` type import, type directly instead
@dannon dannon merged commit 96a3737 into galaxyproject:dev Oct 25, 2023
26 checks passed
@davelopez davelopez mentioned this pull request Oct 25, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davelopez davelopez davelopez left review comments

@ElectronicBlueberry ElectronicBlueberry ElectronicBlueberry left review comments

Assignees
No one assigned
Labels
area/UI-UX kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Milestone
23.2
Development

Successfully merging this pull request may close these issues.
4 participants
@ahmedhamidawan @davelopez @ElectronicBlueberry @dannon