updating recent publications #2825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you have a look at the failing tests? We should stay consistent about our YAML styles, which one we take I don't care much. |
|
@bgruening is that what the problem is (yaml style)? It was unclear from the error messages I was seeing. I'll try repairing it and committing again. |
|
@scottcain The test failure is unrelated to the yaml formatting, but it's something we can fix. I'm opening a PR that'll just autoformat yaml a single consistent way (with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that there was some reformatting introduced by neovim. If that's annoying, I can probably undo it.