Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New check_galaxy_config command to help upgrade a galaxy instance config #40

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

julozi
Copy link

@julozi julozi commented May 8, 2017

The check_galaxy_config command compare two galaxy config files (current config and new sample config) and reports new config options and deprecated options.

…er comparing current galaxy config file to a new galaxy.ini.sample file
@jmchilton
Copy link
Member

Thanks for the contribution - this script looks very helpful!

While useful, I'm not sure I think this belongs here in this project - but perhaps other people envision this project differently than I do. I was hoping to stick to API related functionality here. I think putting this in Galaxy core - say in scripts/ would potentially be a better home. Is there a reason you wanted to contribute it here instead of there?

Also just as a heads up, I do expect the next Galaxy version (17.09) will have YAML config options by default for Galaxy with make targets for linting the config (make config-lint and make config-validate). See galaxyproject/galaxy#3179 for the start of this idea applied to the tool shed and report application.

@julozi
Copy link
Author

julozi commented May 9, 2017

Hi @jmchilton ,
It seems that I have been misinformed ;) I was thinking that ephemeris was "an unofficial random scripts repository". I can move my script to the Galaxy core repo however if the config format is about to change, my script will be deprecated soon.
Do you think it is worth making a pull request on the galaxy core repo ?

@julozi
Copy link
Author

julozi commented May 11, 2017

Any update on this ? Should I make a pull request on the galaxy core repo instead ?

@jmchilton
Copy link
Member

I'd like a second opinion - this is a community effort and other people may disagree with me. Ping @bgruening @mvdbeek - any thoughts on this?

@dannon
Copy link
Member

dannon commented May 15, 2017

(not one of the ones you requested specifically, but I think I'd agree -- having it in galaxyproject/galaxy in the /scripts makes more sense to me)

@bgruening
Copy link
Member

I also think in scripts is perfect - that said I'm still not sure what belongs into this repo here and always surprised about the creativity of our community.
@julozi do you mind submit it into Galaxy core?

@mvdbeek
Copy link
Member

mvdbeek commented May 15, 2017

Maybe we can add @jmchilton's statement from issue #2 to the Readme:
"this project is the realm for things that manage Galaxy but don't require Galaxy - management that leverages the API."

@bgruening
Copy link
Member

@julozi can you add this script to Galaxy main?

@rhpvorderman
Copy link
Contributor

@julozi Has this script been added? I think this PR can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants