Simplify tox.ini, base testing on galaxy-compose #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into simplifytesting
|
It turns out galaxy wait waits 30 seconds without checking anything. Eliminating that from the startup cuts the testing down to 5 minutes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies using tox with any version of python, which is convenient.
Also I made an attempt to get a 'quicker' galaxy. I made a galaxy-compose image which is basically a refactoring of the galaxy-k8s image for docker compose setups. Due to starting a postgres, nginx and galaxy container simultaneously the startup time is improved and testing can commence earlier. This shaves 50 seconds of the testing (7m20 ->6m30).
The galaxy-compose image can easily be updated to newer versions of galaxy and is therefore quite suitable for testing. Images are build weekly.