Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tests mr-c's "when" implementation, https://github.com/galaxyproject/gxformat2/pull/74/commits, which I merged with master of https://github.com/galaxyproject/gxformat2. I imported the resulting source into this repo (which incorporates denis-yuen's recent binding updates) via
updateparser.sh
, added a dependency to the pom to get it building, and modified the appropriate IT to point at a forked test repo that incorporates a "when" clause in a galaxy format 2 file. The test repo is currently in my github account, we can move it if necessary.This code builds, the tests pass, and I was able to load the resulting Galaxy plugin into a develop build of Dockstore and successfully import a Galaxy repo containing two versions: one with a well-formed "when" directive, which Dockstore marks valid, and one with a not-well-formed "when" directive, which Dockstore marks not valid. Dockstore displays a validation error message when I view the latter sourcefile.
The ITs don't currently contain a test for a bad "when" directive (for example, a "when" in the right position, but with malformed value), but I did try to load one while creating the test repo (
when: true
rather thanwhen: "true"
), and the IT failed correctly.So, tentatively, I think it all works!