Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ogc process otb mean shift smoothing #99

Merged

Conversation

MarkusKonk
Copy link
Contributor

This tool acts as a wrapper for an OGC API Process called OTB.MeanShiftSmoothing. It takes the parameters from a user and triggers the service running outside Galaxy.

Note: It works in a similar way as the previous PR created for the tool OTB.BandMath. Here, max values are not possible for every numeric input.

Copy link
Collaborator

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test are unfortunately failing.

If you put all those tool into one directory you could share a lot of code via macros.

@bgruening
Copy link
Collaborator

You can now see the test failures at https://github.com/galaxyecology/tools-ecology/actions/runs/8253335338?pr=99 scroll down please.

@bgruening
Copy link
Collaborator

Also there is .. WARNING: Repository name [OTB.MeanShiftSmoothing] invalid. Repository names must contain only lower-case letters, numbers and underscore.

@MarkusKonk
Copy link
Contributor Author

MarkusKonk commented Mar 13, 2024

Mhh, not sure what is meant by the warning. I tried to change the name in the XML which did not work. Which repository name should I change?

Update: Oh, it's the shed.yaml

@MarkusKonk
Copy link
Contributor Author

is there a way to get a more concrete error message from the lintr? I don't why it still complains. I don't have any issues locally

@bgruening
Copy link
Collaborator

I have only https://github.com/galaxyecology/tools-ecology/actions/runs/8264012065/job/22606726928?pr=99

We could disable the linting again if that is better.

@MarkusKonk
Copy link
Contributor Author

I did the linitng locally in RStudio using the lintr package. I don't see any issues anymore. So, if disabling it for this tool is an option, it would be helpful :)

@bgruening
Copy link
Collaborator

@MarkusKonk
Copy link
Contributor Author

I also used the R styler but it's still failing...I think disabling it is fine ;).

@MarkusKonk
Copy link
Contributor Author

MarkusKonk commented Mar 13, 2024

It's a bit difficult to address the lintr issue if it doesn's provide more concrete descriptions of the issue. And I am also wondering why I get these issue with this tool but not with the previous one which should have the same issues.

@bgruening bgruening merged commit a461559 into galaxyecology:master Mar 13, 2024
11 checks passed
@bgruening bgruening deleted the ogcProcess_otb_meanShiftSmoothing branch March 13, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants