-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ogc process otb mean shift smoothing #99
Ogc process otb mean shift smoothing #99
Conversation
tools/ogcProcess_otb_meanShiftSmoothing/OTB_MeanShiftSmoothing.xml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test are unfortunately failing.
If you put all those tool into one directory you could share a lot of code via macros.
You can now see the test failures at https://github.com/galaxyecology/tools-ecology/actions/runs/8253335338?pr=99 scroll down please. |
Also there is .. WARNING: Repository name [OTB.MeanShiftSmoothing] invalid. Repository names must contain only lower-case letters, numbers and underscore. |
….xml Co-authored-by: Björn Grüning <[email protected]>
Mhh, not sure what is meant by the warning. I tried to change the name in the XML which did not work. Which repository name should I change? Update: Oh, it's the shed.yaml |
…m/AquaINFRA/tools-ecology into ogcProcess_otb_meanShiftSmoothing
is there a way to get a more concrete error message from the lintr? I don't why it still complains. I don't have any issues locally |
I have only https://github.com/galaxyecology/tools-ecology/actions/runs/8264012065/job/22606726928?pr=99 We could disable the linting again if that is better. |
I did the linitng locally in RStudio using the lintr package. I don't see any issues anymore. So, if disabling it for this tool is an option, it would be helpful :) |
You are the R expert, this is what we are using: https://github.com/galaxyecology/tools-ecology/blob/master/.github/styler.R https://github.com/galaxyecology/tools-ecology/blob/master/.github/workflows/pr.yaml#L214 |
I also used the R styler but it's still failing...I think disabling it is fine ;). |
It's a bit difficult to address the lintr issue if it doesn's provide more concrete descriptions of the issue. And I am also wondering why I get these issue with this tool but not with the previous one which should have the same issues. |
This tool acts as a wrapper for an OGC API Process called OTB.MeanShiftSmoothing. It takes the parameters from a user and triggers the service running outside Galaxy.
Note: It works in a similar way as the previous PR created for the tool OTB.BandMath. Here, max values are not possible for every numeric input.