Change divan output label #124
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not totally fixed but we're getting there
Co-authored-by: Björn Grüning <[email protected]>
Co-authored-by: Björn Grüning <[email protected]>
bgruening
reviewed
Aug 6, 2024
| @@ -58,7 +58,7 @@ | |||
| <param name="selmax" type="integer" min="0" max="100" optional="true" value="0" label="Maximum of the salinity"/> | |||
| </inputs> | |||
| <outputs> | |||
| <data name="output_netcdf" label="DIVAnd netcdf output" from_work_dir="outputs_netcdf/*.nc" format="netcdf"/> | |||
| <data name="output_netcdf" label="DIVAnd_output.nc" from_work_dir="outputs_netcdf/*.nc" format="netcdf"/> | |||
There was a problem hiding this comment.
You rely on the Name in your workflow?
There was a problem hiding this comment.
I rely on the extension .nc
The ODV tool does not know ho to read a netcdf if does not have a .nc extension
There was a problem hiding this comment.
But the ODV tool could just ln -s $input ./foo.nc and it would solve it no?
There was a problem hiding this comment.
In the Cheetah code put that ? mmmh not sure what if it's not a netcdf that we input but a tabular this would mess up ODV right ?
bgruening
reviewed
Aug 6, 2024
tools/ocean/divandfull.xml
Outdated
| @@ -2,7 +2,7 @@ | |||
| <description>Data-Interpolating Variational Analysis in n dimensions</description> | |||
| <macros> | |||
| <token name="@TOOL_VERSION@">0.1.0</token> | |||
| <token name="@VERSION_SUFFIX@">0</token> | |||
| <token name="@VERSION_SUFFIX@">0.0.1</token> | |||
There was a problem hiding this comment.
its a simple integer, 0 ... 1... 2...3
There was a problem hiding this comment.
Oh I thought it follows the rule when you have minor fixes 0.0.+1, update 0.+1 or major changes +1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered a tiny glitch when trying to build my workflow this should fix it