Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a new tool with an accessory python script, and also modified the macros.xml file #137

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

thepineapplepirate
Copy link
Contributor

Added a new gromacs tool, gmx insert-molecules. This will allow users to insert many copies of a molecule into a system, using only its .gro file. This tool has many uses, including setting up systems with non-water solvents and adding non-standard solutes (such as complex ions). Virtually any structure with a .gro file can become an inserting molecule. Cheers!

</inputs>
<outputs>
<data name="output1" format="gro" from_work_dir="./multiples.gro" label="GROMACS new structure with inserted-molecules (GRO) on ${on_string}"/>
<data name="output2" format="txt" from_work_dir="./addedmols.txt" label="Total number of molecules succesfully added on ${on_string}"/>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really convinced about this, I guess the idea is that the user modifies the top file themselves? It would be nice if we could do this as part of the tool.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Simon,

We were originally going to make this an all-in-one tool, but we decided to keep it as the standard gmx tool. We are working on a separate "add topologies" tool which will add topologies for inserted molecules, water, NaCL, and everything else. This output containing the number of added molecules would then be used as an input in the next step of adding topologies.

The reason why this is necessary is because not all systems can be setup via the GROMACS initial setup tool (not all force fields are present in gromacs, which leads to unrecognized residue and atom types depending on your system). So having a separate tool that adds topologies will allow versatility for users.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand this correctly, the addedmols.txt will just contain a single integer, with the same value as the nmols parameter? If so, I don't think this is useful, I think the user can take care of this parameter themselves and remembering to use the same value for both tools.

@simonbray simonbray self-assigned this Nov 23, 2021
@simonbray simonbray removed their assignment Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants