Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CreateIdempotent instruction #158

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

iamnotaturtle
Copy link

Adding support for the CreateIdempotent instruction. Also adds support for the Token2022Program for the FindAssociatedTokenAddress method. The instruction seems identical to the Create instruction.

given that solana offers Token2022Program, this change updates the associated-token-account package to pass in a custom TokenProgramId. The logic is similar to the existing ProgramID where we expose a method to set it.
This change adds the CreateIdempotent instruction to the associated token program package. The instruction is here: https://github.com/solana-labs/solana-program-library/blob/6384308a3fa6bef5debfa2e1a0809b24431ddfbd/associated-token-account/program/src/instruction.rs\#L36

The instruction is identical to the Create instruction so the only main changes are the instruction Data and MarshalWithEncoder methods
@iamnotaturtle
Copy link
Author

@gagliardetto what do you think about adding support for the CreateIdempotent instruction for this library?

@iamnotaturtle
Copy link
Author

ping?

@iamnotaturtle
Copy link
Author

@gagliardetto ping?

@gagliardetto
Copy link
Owner

Hi @iamnotaturtle !

Sorry for the long wait, and thanks for opening a PR.

I haven't been keeping up with the changes in the Solana program library; All of the program clients here got outdated. Everything needs to be updated.

Copy link

@QuantumLeaper QuantumLeaper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants