Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for PE-DLL file formats #165

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add support for PE-DLL file formats #165

wants to merge 1 commit into from

Conversation

ne1llee
Copy link
Contributor

@ne1llee ne1llee commented Jul 9, 2021

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.059% when pulling e17d959 on ne1llee:dll into 20e466f on gabriel-vasile:master.

gabriel-vasile
gabriel-vasile reviewed Jul 16, 2021
View reviewed changes
Copy link
Owner

@gabriel-vasile gabriel-vasile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot find any reference for application/vnd.microsoft.portable-executable-dll in the IANA list or anywhere on the internet.
If you need to differentiate between .exe and .dll I suggest to use Extend to customize mimetype for yourself.

@ne1llee
Copy link
Contributor Author

ne1llee commented Jul 20, 2021

Extend could not set the parent node of the custom mimetype , I want to add the DLL to the portable-executable node

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabriel-vasile gabriel-vasile gabriel-vasile left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ne1llee @coveralls @gabriel-vasile