Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Contributing.md to reflect OpenAPI conventions (issue #7) #17

Merged
merged 1 commit into from
Feb 11, 2019

Conversation

sdelatorrep
Copy link
Contributor

Update Contributing.md to reflect OpenAPI conventions (issue #7).

@sdelatorrep
Copy link
Contributor Author

Travis fails because it can't find the files (they are in my local repo but I can't create branches here).

@sdelatorrep
Copy link
Contributor Author

Hi @mcupak , could you have a look at this, please? Thanks!

@mcupak
Copy link
Contributor

mcupak commented Jan 21, 2019

@sdelatorrep Will do. Issue: #18

@mcupak
Copy link
Contributor

mcupak commented Jan 21, 2019

@sdelatorrep I submitted #19 to fix the build issue. Please review and if OK rebase this PR onto it.

@sdelatorrep
Copy link
Contributor Author

sdelatorrep commented Jan 29, 2019

Hi @mcupak , I did the rebase but do you know why Travis is failing with this error?
The job exceeded the maximum log length, and has been terminated.
I saw you also got this error some days ago with the last PR you did but I don't know if you solved it somehow or just ignored it. Many thanks!

@sdelatorrep
Copy link
Contributor Author

Hi @mcupak , please, see my comments here as some things have changed in the Swagger Validator repo.

@mcupak
Copy link
Contributor

mcupak commented Feb 4, 2019

I'll wait for the review of ga4gh-beacon/specification#268, and we can then incorporate a similar solution here.

@mcupak
Copy link
Contributor

mcupak commented Feb 6, 2019

@sdelatorrep #20

@sdelatorrep
Copy link
Contributor Author

Hi @mcupak, could you merge this PR and do a release if there is nothing else missing? I don't have write access so I can't do any of these actions. Thanks!

@mcupak mcupak merged commit 74b0329 into ga4gh:develop Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants