Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add string interpolation to variables in manifest.yml #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JWShuff
Copy link

@JWShuff JWShuff commented Jul 29, 2022

Similar to how table queries can be constructed using variable
stand-ins, to enhance understanding in a manifest.yml file we want to be
able to re use a variable inside the builder for another variable.
Example:

variables:
  book_ids: '1,3,4,10'
  author_ids: 'select * from authors where book_id in (%{book_ids})'

Co-authored-by: Eric Wanchic [email protected]

Similar to how table queries can be constructed using variable
stand-ins, to enhance understanding in a manifest.yml file we want to be
able to re use a variable inside the builder for another variable.
Example:

```yaml
variables:
  book_ids: '1,3,4,10'
  author_ids: 'select * from authors where book_id in (%{book_ids})'
```

Co-authored-by: Eric Wanchic <[email protected]>
@JWShuff JWShuff requested review from wanchic and JohnP42 July 29, 2022 15:50
Copy link

@wanchic wanchic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from when I last remembered 😄 . Thank you for letting me be apart of this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants