Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GridWrap crash when resized to same size before renderer created #5412

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

dweymouth
Copy link
Contributor

@dweymouth dweymouth commented Jan 15, 2025

Description:

GridWrap would crash if resized to its current size before its renderer is created (since BaseWidget.Resize to the same size is a no-op and doesn't create the renderer). I ran into this in Supersonic, in my system of widget reuse, and had worked around it but figured out the root cause and a proper fix.

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@coveralls
Copy link

Coverage Status

coverage: 59.209% (+0.02%) from 59.189%
when pulling 5df62d2 on dweymouth:gridwrap-crash-before-renderer
into d7eeddc on fyne-io:develop.

@dweymouth dweymouth merged commit a41cb86 into fyne-io:develop Jan 15, 2025
12 checks passed
@dweymouth dweymouth deleted the gridwrap-crash-before-renderer branch January 15, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants